Is it possible to commit new "regex" module before 1.5?

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

Is it possible to commit new "regex" module before 1.5?

Iñaki Baz Castillo
Hi, I planned to commit a new module called "Regex" in SVN trunk but I was
away these last days and couldn't submit it before the SVN freeze
(yesterday).

I know that no new code should be submitted in this moment, but this module is
already tested and working in Kamailio (and of course I've also checked it in
OpenSIPS trunk version). For now there are no bugs/issues with it.

Would you, developers, accept this module now or should I wait until 1.5 is
released?

Thanks and best regards.


PD: Regex module documentation in Kamailio:
      http://kamailio.org/docs/modules/devel/regex.html

--
Iñaki Baz Castillo

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Reply | Threaded
Open this post in threaded view
|

Re: Is it possible to commit new "regex" module before 1.5?

Bogdan-Andrei Iancu
Hi Iñaki,

Personally I think we can make an exception, given the circumstances. If
the new code is tested and does not affect the overall stability of the
code (which is the most important think here), we can be a bit flexible
and go for it.

I'm also interested in hearing other people opinion on this.

IMHO the important is the goal and not the rules to get to the goal :D......

Regards,
Bogdan

Iñaki Baz Castillo wrote:

> Hi, I planned to commit a new module called "Regex" in SVN trunk but I was
> away these last days and couldn't submit it before the SVN freeze
> (yesterday).
>
> I know that no new code should be submitted in this moment, but this module is
> already tested and working in Kamailio (and of course I've also checked it in
> OpenSIPS trunk version). For now there are no bugs/issues with it.
>
> Would you, developers, accept this module now or should I wait until 1.5 is
> released?
>
> Thanks and best regards.
>
>
> PD: Regex module documentation in Kamailio:
>       http://kamailio.org/docs/modules/devel/regex.html
>
>  


_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Reply | Threaded
Open this post in threaded view
|

Re: Is it possible to commit new "regex" module before 1.5?

Sergio Gutierrez
Hi all.

I agree with Bogdan. According module documentation, it offers a very useful functionality, which would be nice to include it in 1.5.0.

Regards.

Sergio.

On Tue, Feb 17, 2009 at 7:53 AM, Bogdan-Andrei Iancu <[hidden email]> wrote:
Hi Iñaki,

Personally I think we can make an exception, given the circumstances. If
the new code is tested and does not affect the overall stability of the
code (which is the most important think here), we can be a bit flexible
and go for it.

I'm also interested in hearing other people opinion on this.

IMHO the important is the goal and not the rules to get to the goal :D......

Regards,
Bogdan

Iñaki Baz Castillo wrote:
> Hi, I planned to commit a new module called "Regex" in SVN trunk but I was
> away these last days and couldn't submit it before the SVN freeze
> (yesterday).
>
> I know that no new code should be submitted in this moment, but this module is
> already tested and working in Kamailio (and of course I've also checked it in
> OpenSIPS trunk version). For now there are no bugs/issues with it.
>
> Would you, developers, accept this module now or should I wait until 1.5 is
> released?
>
> Thanks and best regards.
>
>
> PD: Regex module documentation in Kamailio:
>       http://kamailio.org/docs/modules/devel/regex.html
>
>


_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel



--
Sergio Gutiérrez

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Reply | Threaded
Open this post in threaded view
|

Re: Is it possible to commit new "regex" module before 1.5?

Dan Pascu
In reply to this post by Bogdan-Andrei Iancu
On Tuesday 17 February 2009, Bogdan-Andrei Iancu wrote:
> Hi Iñaki,
>
> Personally I think we can make an exception, given the circumstances.
> If the new code is tested and does not affect the overall stability of
> the code (which is the most important think here), we can be a bit
> flexible and go for it.
>
> I'm also interested in hearing other people opinion on this.

I see no harm in adding it. It's a standalone module so it can't affect
the rest of the code. Besides it was an issue of timing to push it into
svn and a 1 day delay it's not that big of an issue.

>
> IMHO the important is the goal and not the rules to get to the goal
> :D......
>
> Regards,
> Bogdan
>
> Iñaki Baz Castillo wrote:
> > Hi, I planned to commit a new module called "Regex" in SVN trunk but
> > I was away these last days and couldn't submit it before the SVN
> > freeze (yesterday).
> >
> > I know that no new code should be submitted in this moment, but this
> > module is already tested and working in Kamailio (and of course I've
> > also checked it in OpenSIPS trunk version). For now there are no
> > bugs/issues with it.
> >
> > Would you, developers, accept this module now or should I wait until
> > 1.5 is released?
> >
> > Thanks and best regards.
> >
> >
> > PD: Regex module documentation in Kamailio:
> >       http://kamailio.org/docs/modules/devel/regex.html
>
> _______________________________________________
> Devel mailing list
> [hidden email]
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel



--
Dan

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Reply | Threaded
Open this post in threaded view
|

Re: Is it possible to commit new "regex" module before 1.5?

Iñaki Baz Castillo
2009/2/18 Dan Pascu <[hidden email]>:

> On Tuesday 17 February 2009, Bogdan-Andrei Iancu wrote:
>> Hi Iñaki,
>>
>> Personally I think we can make an exception, given the circumstances.
>> If the new code is tested and does not affect the overall stability of
>> the code (which is the most important think here), we can be a bit
>> flexible and go for it.
>>
>> I'm also interested in hearing other people opinion on this.
>
> I see no harm in adding it. It's a standalone module so it can't affect
> the rest of the code. Besides it was an issue of timing to push it into
> svn and a 1 day delay it's not that big of an issue.

Thanks to all, I will submit it today.

Best regards.

--
Iñaki Baz Castillo
<[hidden email]>

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Reply | Threaded
Open this post in threaded view
|

Re: Is it possible to commit new "regex" module before 1.5?

Bogdan-Andrei Iancu
Hi Inaki,

Please proceed - I want to have the final update list of all the changes
in 1.5 ready :)

Thanks and regards,
Bogdan

Iñaki Baz Castillo wrote:

> 2009/2/18 Dan Pascu <[hidden email]>:
>  
>> On Tuesday 17 February 2009, Bogdan-Andrei Iancu wrote:
>>    
>>> Hi Iñaki,
>>>
>>> Personally I think we can make an exception, given the circumstances.
>>> If the new code is tested and does not affect the overall stability of
>>> the code (which is the most important think here), we can be a bit
>>> flexible and go for it.
>>>
>>> I'm also interested in hearing other people opinion on this.
>>>      
>> I see no harm in adding it. It's a standalone module so it can't affect
>> the rest of the code. Besides it was an issue of timing to push it into
>> svn and a 1 day delay it's not that big of an issue.
>>    
>
> Thanks to all, I will submit it today.
>
> Best regards.
>
>  


_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Reply | Threaded
Open this post in threaded view
|

Re: Is it possible to commit new "regex" module before 1.5?

Iñaki Baz Castillo
2009/2/18 Bogdan-Andrei Iancu <[hidden email]>:
> Hi Inaki,
>
> Please proceed - I want to have the final update list of all the changes in
> 1.5 ready :)

Already commited. I just forgot to set:
  svn propset svn:keywords "Author Date Id Revision"
in some files.

I've already added it in my local repository but I don't know how to
submit those changes. Must I modify the files?

Thanks.

--
Iñaki Baz Castillo
<[hidden email]>

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Reply | Threaded
Open this post in threaded view
|

Re: Is it possible to commit new "regex" module before 1.5?

Iñaki Baz Castillo
2009/2/18 Iñaki Baz Castillo <[hidden email]>:
> Already commited. I just forgot to set:
>  svn propset svn:keywords "Author Date Id Revision"
> in some files.
>
> I've already added it in my local repository but I don't know how to
> submit those changes. Must I modify the files?

Ok, when doing a "svn co" the keywords "Date", "Author" and so are
correctly filled, so it's ok now. I expect that "svn ci" after "svn
propset svn:keywords "Author Date Id Revision" FILE" did work.

Regards.


--
Iñaki Baz Castillo
<[hidden email]>

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Reply | Threaded
Open this post in threaded view
|

Re: Is it possible to commit new "regex" module before 1.5?

Bogdan-Andrei Iancu
In reply to this post by Iñaki Baz Castillo
Iñaki Baz Castillo wrote:
> 2009/2/18 Bogdan-Andrei Iancu <[hidden email]>:
>  
>> Hi Inaki,
>>
>> Please proceed - I want to have the final update list of all the changes in
>> 1.5 ready :)
>>    
>
> Already commited.
Perfect - thank you
> I just forgot to set:
>   svn propset svn:keywords "Author Date Id Revision"
> in some files.
>  
you can do it anytime
> I've already added it in my local repository but I don't know how to
> submit those changes. Must I modify the files?
>  
set the property and simply commit - it should do the work ;)

BTW, I fixed (hopefully) your display name in the commit
notifications....Sorry about that :)


Regards,
Bogdan


_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Reply | Threaded
Open this post in threaded view
|

Re: Is it possible to commit new "regex" module before 1.5?

Sergio Gutierrez
In reply to this post by Iñaki Baz Castillo

Hi Iñaki.

I added autodetection of PCRE library and additional locations for searching the library, to make module more portable, to systems as Solaris.

I apologize for doing it before consulting you, but I did not want to come without a result! :-)

Regards.

Sergio.

On Wed, Feb 18, 2009 at 5:32 AM, Iñaki Baz Castillo <[hidden email]> wrote:
2009/2/18 Iñaki Baz Castillo <[hidden email]>:
> Already commited. I just forgot to set:
>  svn propset svn:keywords "Author Date Id Revision"
> in some files.
>
> I've already added it in my local repository but I don't know how to
> submit those changes. Must I modify the files?

Ok, when doing a "svn co" the keywords "Date", "Author" and so are
correctly filled, so it's ok now. I expect that "svn ci" after "svn
propset svn:keywords "Author Date Id Revision" FILE" did work.

Regards.


--
Iñaki Baz Castillo
<[hidden email]>

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel



--
Sergio Gutiérrez

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Reply | Threaded
Open this post in threaded view
|

Re: Is it possible to commit new "regex" module before 1.5?

Iñaki Baz Castillo
2009/2/18 Sergio Gutierrez <[hidden email]>:
>
> Hi Iñaki.
>
> I added autodetection of PCRE library and additional locations for searching
> the library, to make module more portable, to systems as Solaris.
>
> I apologize for doing it before consulting you, but I did not want to come
> without a result! :-)

It's ok, thanks a lot.

--
Iñaki Baz Castillo
<[hidden email]>

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel