[OpenSIPS/opensips] 5df8b6: pua: Fix some list management bugs; Improve code

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[OpenSIPS/opensips] 5df8b6: pua: Fix some list management bugs; Improve code

Bogdan Andrei IANCU
  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 5df8b636a15a799b5f1ab7a58ebe1c208ce49d2d
      https://github.com/OpenSIPS/opensips/commit/5df8b636a15a799b5f1ab7a58ebe1c208ce49d2d
  Author: Liviu Chircu <[hidden email]>
  Date:   2020-07-08 (Wed, 08 Jul 2020)

  Changed paths:
    M modules/pua/uri_list.h

  Log Message:
  -----------
  pua: Fix some list management bugs; Improve code

    * do not use strncmp() to compare "str" structs, since it may lead
      to false positives (e.g. strncmp("foobar", "foo", 3) == 0).  Use
      str_match() or str_strcmp() instead.

    * do not read memory after pkg_free() (severity: low, since it's PKG
      memory, so reading "invalid" heap memory works anyway...)

    * simplify list_pop() and list_free() code



_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel