[OpenSIPS/opensips] 9e74f3: acc: Improve code quality

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[OpenSIPS/opensips] 9e74f3: acc: Improve code quality

Liviu Chircu
  Branch: refs/heads/2.3
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9e74f37bb7408062babf753f303598378ad1043a
      https://github.com/OpenSIPS/opensips/commit/9e74f37bb7408062babf753f303598378ad1043a
  Author: Liviu Chircu <[hidden email]>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/acc/acc_extra.c
    M modules/acc/acc_extra.h
    M modules/acc/acc_logic.c
    M modules/acc/acc_logic.h
    M modules/acc/acc_vars.c

  Log Message:
  -----------
  acc: Improve code quality

    * rename expand_legs() -> push_leg() (self-explanatory)
    * do not use non-paranthesized macros as functions
    * simplify store_acc_table() and avoid shm_realloc() leak on oom
    * do not pass redundant function parameters
    * remove redundant ACC_PUT_CTX() calls
    * use str_strcmp() for added readability
    * acc_onreply_in(): improve readability

(cherry picked from commit 13c8244691db9541c92e45ab74d1e0a57cdbdf63)


  Commit: 9d1ff8450d55968c2d9f88a9fc887d924ed699b7
      https://github.com/OpenSIPS/opensips/commit/9d1ff8450d55968c2d9f88a9fc887d924ed699b7
  Author: Liviu Chircu <[hidden email]>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/acc/acc.c

  Log Message:
  -----------
  acc: Fix constant-sized pkg leak on startup

(cherry picked from commit 1c60e0e49fd1f53c316fc8affd296f99fa83d39f)


  Commit: 27458e72b03b515ef0466d3e7c5bf679412c6e61
      https://github.com/OpenSIPS/opensips/commit/27458e72b03b515ef0466d3e7c5bf679412c6e61
  Author: Liviu Chircu <[hidden email]>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/dialog/dlg_cb.h

  Log Message:
  -----------
  dialog: Document the callbacks

(cherry picked from commit 849ca807c7792a0598d53907328044718845f282)


  Commit: 93435285415215fec648d6cfcfd3205e643fc496
      https://github.com/OpenSIPS/opensips/commit/93435285415215fec648d6cfcfd3205e643fc496
  Author: Liviu Chircu <[hidden email]>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/dialog/dlg_cb.c
    M modules/dialog/dlg_cb.h
    M modules/dialog/dlg_handlers.c

  Log Message:
  -----------
  dialog: Remove unused function and parameter

(cherry picked from commit bc840ad7bd2dc4cc785abd0b4df8c06790e2b09e)


  Commit: 1ecee22afda387d730bc2d2b58f223abc4afa9d1
      https://github.com/OpenSIPS/opensips/commit/1ecee22afda387d730bc2d2b58f223abc4afa9d1
  Author: Liviu Chircu <[hidden email]>
  Date:   2018-10-01 (Mon, 01 Oct 2018)

  Changed paths:
    M modules/mid_registrar/save.c

  Log Message:
  -----------
  mid_registrar: Fix segfault on invalid AoR parameter

How to reproduce:
    mid_registrar_save("location", , "3600");
        (misplaced parameter: we actually provide a bad AoR SIP URI!)

(cherry picked from commit f24351189abb9acc4da1f0485c173f8f02fded3b)


Compare: https://github.com/OpenSIPS/opensips/compare/f92822258009...1ecee22afda3
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel