SF.net SVN: opensips:[6041] branches/1.5/modules/rls/subscribe.c

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

SF.net SVN: opensips:[6041] branches/1.5/modules/rls/subscribe.c

Anca Vamanu-2
Revision: 6041
          http://opensips.svn.sourceforge.net/opensips/?rev=6041&view=rev
Author:   anca_vamanu
Date:     2009-08-28 11:38:22 +0000 (Fri, 28 Aug 2009)

Log Message:
-----------
- revert change made in commit rev #4944: return to_presence code for Subscribe messages that contain Supported:eventlist header but for which a list definition is not found

Revision Links:
--------------
    http://opensips.svn.sourceforge.net/opensips/?rev=4944&view=rev

Modified Paths:
--------------
    branches/1.5/modules/rls/subscribe.c


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Reply | Threaded
Open this post in threaded view
|

SF.net SVN: opensips:[6041] branches/1.5/modules/rls/subscribe.c

Juha Heinanen
Anca Vamanu writes:

 > - revert change made in commit rev #4944: return to_presence code for
 > - Subscribe messages that contain Supported:eventlist header but for
 > - which a list definition is not found

anca,

in case of in-dialog subscribe, the module still returns 404 if document
is not found.

isn't the idea that rls_handle_subscribe() can be called also for
in-dialog requests and get 'to_presence_code' back if the in-dialog
subscribe was not for rls server?

-- juha

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Reply | Threaded
Open this post in threaded view
|

SF.net SVN: opensips:[6041] branches/1.5/modules/rls/subscribe.c

Juha Heinanen
In reply to this post by Anca Vamanu-2
anca,

regarding in-dialog subscribe requests, perhaps it could be checked
in the script if the request is for rls server or not, for example,
checking that request uri matches server_address.  if so, then
rls_handle_subscribe would not need to handle non-list subscribes.

-- juha

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
Reply | Threaded
Open this post in threaded view
|

Re: SF.net SVN: opensips:[6041] branches/1.5/modules/rls/subscribe.c

Anca Vamanu-2
Hi Juha,

You are right, I fixed that.

Thanks,
Anca

Juha Heinanen wrote:

> anca,
>
> regarding in-dialog subscribe requests, perhaps it could be checked
> in the script if the request is for rls server or not, for example,
> checking that request uri matches server_address.  if so, then
> rls_handle_subscribe would not need to handle non-list subscribes.
>
> -- juha
>
> _______________________________________________
> Devel mailing list
> [hidden email]
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>
>  


_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel