[ opensips-Bugs-2827960 ] loose routed messages may use wrong outbound port

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[ opensips-Bugs-2827960 ] loose routed messages may use wrong outbound port

SourceForge.net
Bugs item #2827960, was opened at 2009-07-27 20:46
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2827960&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
>Status: Closed
Resolution: Fixed
Priority: 7
Private: No
Submitted By: Peter Baer (peter_baer)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: loose routed messages may use wrong outbound port

Initial Comment:
loose_route() does not select the correct socket for relayed packets if the route header does not have a port specified and the proxy is setup to use more than one listening port (using same protocol).

So for example:
listen=192.168.1.100:15061
listen=192.168.1.100:5060

A request comes in on socket 192.168.1.100:15061 with route header:
Route: <sip:192.168.1.100:15061;r2=on;lr;ftag=71737667aac2b773o1>, <sip:192.168.1.100;r2=on;lr;ftag=71737667aac2b773o1>.

When loose_route gets called grep_sock_info() does not match on port because we look at 2nd route that has no port specified:
<sip:192.168.1.100;r2=on;lr;ftag=71737667aac2b773o1>

This causes the message is to be sent out on 192.168.1.100:15061 instead of 192.168.1.100:5060.

There is an attached patch that fixes this bug, but it has only been tested on 1.3.

----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2009-08-04 19:46

Message:
tested by myself - seams to be everything ok, backport to 1.5 was done.

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2009-07-28 19:49

Message:
OK - the fix is on the SVN trunk - if you could test it again , it will be
great as I will be moving forward with the backport to 1.5 branch.

Thanks and regards,
Bogdan

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2009-07-28 17:45

Message:
Hi Peter,

Thanks for the report and the fix - I'm working on it right now as more
changes are required. The protocol par tis also affected by a similar bug.
Also this is not only RR specific, but other parts of the code are
affected.

Regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2827960&group_id=232389

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel