[ opensips-Bugs-2941492 ] the second transaction is not linked with the dialog

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[ opensips-Bugs-2941492 ] the second transaction is not linked with the dialog

SourceForge.net
Bugs item #2941492, was opened at 2010-01-28 11:24
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2941492&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.5.x
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Alexey Popov (aap061)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: the second transaction is not linked with the dialog

Initial Comment:
If we have multiple transactions within one dialog, all of them must be linked to the dialog.
Overwise, reply route can't use dialog flags for the second and all the following transactions.

This situation can be easily reproduced for re-INVITE case

Proposal solution is attached

Thanks,
Alexey

----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2010-03-11 14:35

Message:
Ok, I did my own fix for this, so to solve all related issues and races -
please update from SVN.

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2010-02-09 19:47

Message:
Hi Alexey,

indeed the report is correct, but not the fix - you link the dialog to the
follow-up transactions without ref counting the dialog (to prevent it to be
removed from other places).
The correct approach is to ref count the dialog (when attached) and to
register to the transaction a DESTROY callback to do the unref for the
dialog (when the transaction is deleted).

Let me know if you re-work the patch, otherwise I will do it.

Regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2941492&group_id=232389

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel