[ opensips-Bugs-2955193 ] Completion of error handling

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[ opensips-Bugs-2955193 ] Completion of error handling

SourceForge.net
Bugs item #2955193, was opened at 2010-02-19 23:21
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2955193&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: 1.6.x
>Status: Closed
>Resolution: Invalid
Priority: 5
Private: No
Submitted By: Markus Elfring (elfring)
Assigned to: Nobody/Anonymous (nobody)
Summary: Completion of error handling

Initial Comment:
Some checks for return codes are missing.

Examples:
Would you like to add more error handling for return values from "fclose" like in the function "daemonize" and from "semctl" in the function "lock_set_destroy"?
http://opensips.svn.sourceforge.net/viewvc/opensips/trunk/daemonize.c?revision=5902&view=markup
http://opensips.svn.sourceforge.net/viewvc/opensips/trunk/lock_ops.h?revision=6581&view=markup

----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2010-03-04 18:02

Message:
Hi Markus,

the return code of fclose function (in this case) is totally irrelevant
for the further processing. If indeed the file closing failed, there is
nothing to do about , because you are already done with the file
processing. Maybe just for logging purposes, but once the file was open,
there is no reason for the fclose to fail.

For the semctl is the same - it is a failure to destroy a resource - and
the destroy is anyhow done at shutdown time only.

Thanks and regards,
Bogdan


----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=2955193&group_id=232389

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel