[ opensips-Patches-2351158 ] Pseudovar argument for sleep function at cfgutils.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[ opensips-Patches-2351158 ] Pseudovar argument for sleep function at cfgutils.

SourceForge.net
Patches item #2351158, was opened at 2008-11-26 17:16
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2351158&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: None
Status: Open
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Sergio Gutierrez (saguti)
>Assigned to: Sergio Gutierrez (saguti)
Summary: Pseudovar argument for sleep function at cfgutils.

Initial Comment:
Based on a question posted by a user, this patch implements the feature of allowing sleep function at cfgutils module receives a pseudovariable argument.

This patch is a very first approach, and in case of being accepted, it could be applied to usleep function too.
A couple questions:

1. What should be the module's behaviour when argument as invalid value/format (Ignore/log the error, or stop execution?)
2. Should the current behaviour be kept? That is to say, still receive a string as argument, or should it be completely overrided by pseudovar usage? In case that it should be kept, is there a way to do it in the same function? As I see, a new function should be implemented, as fixup functions are different for pseudovar and string.

Thanks in advance for your attention.

Sergio

----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-12-12 12:15

Message:
Hi Sergio,

As discussed per email, please feel free an upload the patch on SVN..

Thanks and regards,
Bogdan

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-12-04 14:32

Message:
Hi Sergio,

some remarks:

1) your patch defines a new function m_sleep2(),  but I do no see it
triggered from the module export structure (you changed only the fixup
function) ...also, what about the old m_sleep() function ?

2) please update the docs also (about what params the function accepts)

3) please use consistent code indentation (use only tabs for this, without
spaces)

Thanks and regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2351158&group_id=232389

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel