[ opensips-Patches-2694523 ] fix: tm: msg_builder : Invalid generated headers

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[ opensips-Patches-2694523 ] fix: tm: msg_builder : Invalid generated headers

SourceForge.net
Patches item #2694523, was opened at 2009-03-19 16:10
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2694523&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Christophe Sollet (csollet)
Assigned to: Nobody/Anonymous (nobody)
Summary: fix: tm: msg_builder : Invalid generated headers

Initial Comment:
When display name is not present but header tags exists, built To: and From: headers are invalid since header tags become URI tags ('<' and '>' are missing) :

Original Header :

From: DisplayName <sip:user@domain;uritag=val>;htag=value
From: sip:user@domain;uritag=val
From: <sip:user@domain;uritag=val>;htag=value

Current tm implementation :

From: DisplayName <sip:user@domain;uritag=val>;htag=value (VALID)
From: sip:user@domain;uritag=val (VALID)
From: sip:user@domain;uritag=val;htag=value (INVALID)

With attached patch :

From: DisplayName <sip:user@domain;uritag=val>;htag=value (VALID)
From: sip:user@domain;uritag=val (VALID)
From: <sip:user@domain;uritag=val>;htag=value (VALID)



----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2009-03-20 16:22

Message:
Hi,

According to the RFC3261, the syntax is:

from-spec   =  ( name-addr / addr-spec ) *( SEMI from-param )

name-addr      =  [ display-name ] LAQUOT addr-spec RAQUOT


So, if there is no <>, the params are hdr params and not URI params. So,
in:
  From: sip:user@domain;uritag=val

uritag is actually a FROM HDR param and not an URI param

Also:
   From: sip:user@domain;uritag=val;htag=value

is correct as the both are FROM hdr params

Regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2694523&group_id=232389

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel