[ opensips-Patches-2788192 ] fix: cpl - branch flags not getting initialized correctly

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[ opensips-Patches-2788192 ] fix: cpl - branch flags not getting initialized correctly

SourceForge.net
Patches item #2788192, was opened at 2009-05-07 06:38
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2788192&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.5.x
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: John Riordan (john_riordan)
>Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: fix: cpl - branch flags not getting initialized correctly

Initial Comment:
Hey Bogdan,

This is #2785741 again.

I just updated and it looks like my fix may have been lost in translation. The change which got implemented only partially fixes the problem I'm trying to solve.

Please bare with me while I attempt to explain the issue better. As I understand it (little that I do), the cpl proxy code implements sequential "ordering" by first creating a list of locations (location set). It then removes the first location from the head of the list, attempts to relay it, and then repeats until there are no more locations left in the list (or a positive final response). If additional branch flags are set while processing the first location (in the script branch_route for example), they are not getting cleared when the second location begins to be processed (as branch 0 again). The fix you implemented now initializes the nat branch flag correctly, but doesn't clear other flags that may have been set and these unexpectedly get carried over into for the next location processed. The patch attached completely clears the branch flags each time branch 0 is reused during this process. Note that an example of the correct behavior is implemented in the existing code a few lines down in the loop that add additional branches for parallel processing.

Cheers,

John


----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2009-05-09 10:13

Message:
Hi John,

You are right - I overlooked this aspect. Thank you for point this out. I
applied the patch in the original form :)

Thanks and regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2788192&group_id=232389

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel