[ opensips-Patches-2847397 ] Better blf support for linksys phones

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[ opensips-Patches-2847397 ] Better blf support for linksys phones

SourceForge.net
Patches item #2847397, was opened at 2009-08-30 21:15
Message generated for change (Comment added) made by anmar
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2847397&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
>Group: 1.6.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Angel Marin (anmar)
Assigned to: Anca Vamanu (anca_vamanu)
Summary: Better blf support for linksys phones

Initial Comment:
With current implementation, if there's no ongoing or terminated dialog registered in the presentity table, presence_dialoginfo sends a notify with empty body as reply to a subscribe.

This makes BLF support incomplete for phones that only register to dialog-info event (linksys), so they won't know the state of the subscribed uri until it makes a call.

The attached patch adds the ability to presence_dialoginfo to build a dialog-info body that reports the state of a dialog as terminated when there's no dialog, but we have a presentity entry for that user. Something like:

<?xml version="1.0"?>
<dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info"
        version="0"
        state="full"
        entity="sip:[hidden email]">
        <dialog id="sip:[hidden email]">
                <state>terminated</state>
        </dialog>
</dialog-info>

The patch also adds a contains_presence api function to presence module so we can check if there's a presence entry registered for a given uri.

I've tested it only with linksys spa-9x2 phones, but it's trivial enough to not make any other phone unhappy.

This makes support for linksys blf a little better, but it's still missing a similar notify when the monitored user registers after the subscribe. Right now the subscriber won't get notified until it resubscribes.

diff against 1.5.3


----------------------------------------------------------------------

>Comment By: Angel Marin (anmar)
Date: 2010-03-04 18:59

Message:
I've attached the latest version of the patch we've been running in
production since early November.

In the original patch did not return the fake dialog-info body when body
aggregation discards all stored dialogs.

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2010-03-04 18:51

Message:
It would be nice to have this enhancement in the 1.6.2 release.

----------------------------------------------------------------------

Comment By: Angel Marin (anmar)
Date: 2010-03-04 18:42

Message:
Thanks Anca, that's great news. Then I'll dig up the actual version we're
running in production now on 1.6.x.

----------------------------------------------------------------------

Comment By: Anca Vamanu (anca_vamanu)
Date: 2010-03-04 18:32

Message:
Hi Angel,

I will review your patch and most probably accept it.

Regards,
Anca

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=2847397&group_id=232389

_______________________________________________
Devel mailing list
[hidden email]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel